Skip to content

Upgraded Storybook to v10#7008

Merged
bdukes merged 9 commits intodnnsoftware:developfrom
valadas:storybook-fix20260218
Feb 24, 2026
Merged

Upgraded Storybook to v10#7008
bdukes merged 9 commits intodnnsoftware:developfrom
valadas:storybook-fix20260218

Conversation

@valadas
Copy link
Copy Markdown
Contributor

@valadas valadas commented Feb 18, 2026

Supersedes #6961

  • We had a mix of v9 and v10 packages causing a build issue, I first reverted the v10 packages to their latest v9 versions.
  • Then I ran into an issue with svgr support within storybook, which I fixed.
  • I then ran storybook upprade tool to bring us to latest v9.
  • Then I reran the storybook upgrade tool to bring us to latest (v10)

@bdukes
Copy link
Copy Markdown
Contributor

bdukes commented Feb 18, 2026

You may need to bump the versions down or wait a bit and re-run. We require npm packages to have been published for at least 24 hours before we upgrade for security reasons.

@valadas
Copy link
Copy Markdown
Contributor Author

valadas commented Feb 18, 2026

You may need to bump the versions down or wait a bit and re-run. We require npm packages to have been published for at least 24 hours before we upgrade for security reasons.

Oh, I did not know that, I can re-run it tomorrow or such...

@bdukes bdukes force-pushed the storybook-fix20260218 branch from 2de8c08 to b672c02 Compare February 20, 2026 16:09
@bdukes
Copy link
Copy Markdown
Contributor

bdukes commented Feb 20, 2026

I can't tell what the issue is with this PR. The commit that I pushed fixes one issue, but your first commit now causes an error in the Admin Experience build script. I don't know if maybe it's causing some files not to get generated, so the resource zip doesn't get created? I failed to track down a real source cause.

@valadas
Copy link
Copy Markdown
Contributor Author

valadas commented Feb 20, 2026

Yeah, we may need to investigate further. I ran storybook from its local place and did not do a full build of everything.

@valadas
Copy link
Copy Markdown
Contributor Author

valadas commented Feb 24, 2026

@bdukes I rebased and resolved conflicts and it worked (on my machine). Crossing fingers for CI ;)

@bdukes bdukes merged commit d29c918 into dnnsoftware:develop Feb 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants