Skip to content

Fix CDF issues#7002

Merged
bdukes merged 15 commits intodnnsoftware:developfrom
donker:fix-cdv-feb-1
Feb 18, 2026
Merged

Fix CDF issues#7002
bdukes merged 15 commits intodnnsoftware:developfrom
donker:fix-cdv-feb-1

Conversation

@donker
Copy link
Copy Markdown
Contributor

@donker donker commented Feb 14, 2026

This PR fixes these issues:

  1. Multiple attributes being added while using different casing (mentioned in [Bug]: CDF - Multiple Issues Using New Fluent API, CreateStylesheet() -- v10.02.01 #6903 )
  2. Remove double slashes from links to resources in skin path (mentioned in [Bug]: CDF - Two Small Issues Rendering DnnXxIncludes -- v10.02.00 RC2 #6850)
  3. Ensure no attribute can be added that has been added by the other resource methods

@donker donker added this to the 10.2.3 milestone Feb 14, 2026
@donker donker self-assigned this Feb 14, 2026
@donker donker mentioned this pull request Feb 14, 2026
Closed
2 tasks
This was referenced Feb 14, 2026
Closed
Closed
Closed
valadas
valadas reviewed Feb 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, just one little concern that may or may not be valid...

@jeremy-farrance
Copy link
Copy Markdown
Contributor

jeremy-farrance commented Feb 16, 2026 •
edited
Loading

Reran tests, some still failing. Revised summary/results in the hopes of saving you time and making the situation/status more clear. See newest comment on #6850.

See #issuecomment-3908975408

@jeremy-farrance
Copy link
Copy Markdown
Contributor

jeremy-farrance commented Feb 16, 2026 •
edited
Loading

Fixed!!

Everything I was testing for is all fixed now. Details posted on Issue #6850, new comment.

@donker
Copy link
Copy Markdown
Contributor Author

donker commented Feb 16, 2026

Fixed!!

Everything I was testing for is all fixed now. Details posted on Issue #6850, new comment.

Thanks for your help in testing this, Jeremy!

bdukes
bdukes reviewed Feb 17, 2026
View reviewed changes
@jeremy-farrance
Copy link
Copy Markdown
Contributor

jeremy-farrance commented Feb 18, 2026

Is there some way to set something so I get notified when the build succeeds?

@bdukes
Copy link
Copy Markdown
Contributor

bdukes commented Feb 18, 2026

I'm not aware of a way to get notified of that.

I've rebased this branch, hoping that fixes the build issue.

@bdukes
Copy link
Copy Markdown
Contributor

bdukes commented Feb 18, 2026

Ah, nevermind, it's broken from #7006 (because of drift between the PR and develop). I'll get on a PR to fix that.

@bdukes
Copy link
Copy Markdown
Contributor

bdukes commented Feb 18, 2026

Build fixed in #7007, I've rebased this PR on top of it.

@bdukes
Copy link
Copy Markdown
Contributor

bdukes commented Feb 18, 2026

@jeremy-farrance here's your notification that the build is complete

@jeremy-farrance
Copy link
Copy Markdown
Contributor

jeremy-farrance commented Feb 18, 2026

Not sure it was needed, but "Still fixed." Identical results with Build 75. 💯

@bdukes bdukes merged commit ae4f311 into dnnsoftware:develop Feb 18, 2026
3 checks passed
@bdukes bdukes mentioned this pull request Feb 18, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdukes bdukes bdukes approved these changes

@valadas valadas valadas approved these changes

Assignees

@donker donker

Labels

Area: Platform > JavaScript Libraries Area: Platform > Library Type: Bug

Projects

Issue Triage
Status: No status

Milestone

10.2.3

Development

Successfully merging this pull request may close these issues.

4 participants

@donker @jeremy-farrance @bdukes @valadas