Skip to content

Don't include System.Memory in install or upgrade#6996

Merged
bdukes merged 2 commits intodnnsoftware:developfrom
bdukes:remove-system.memory
Feb 23, 2026
Merged

Don't include System.Memory in install or upgrade#6996
bdukes merged 2 commits intodnnsoftware:developfrom
bdukes:remove-system.memory

Conversation

@bdukes
Copy link
Copy Markdown
Contributor

@bdukes bdukes commented Feb 13, 2026

Fixes #6993

This PR has not yet been tested, I'm not certain if the installer works without the assembly, but I believe it should work.

@donker
Copy link
Copy Markdown
Contributor

donker commented Feb 13, 2026

Bummer. The install wizard needs it.

Screenshot 2026-02-13 at 21 16 57

@donker
Copy link
Copy Markdown
Contributor

donker commented Feb 13, 2026

I tried moving this to exclude only in upgrade but now I am getting a different dll issue when trying to upgrade a plain vanilla 9.13.10 to 10.2.3:

Screenshot 2026-02-13 at 22 02 04

Maybe we need to rethink this.

@bdukes bdukes force-pushed the remove-system.memory branch from 20de741 to fc8676c Compare February 17, 2026 18:45
@bdukes
Copy link
Copy Markdown
Contributor Author

bdukes commented Feb 17, 2026

I've pushed a commit which avoids using the string.Contains extension method from System.Memory, instead introducing our own extension method in DotNetNuke.Common.Utilities.StringExtensions. This allows the install wizard to load without an error when System.Memory is missing.

@bdukes
Copy link
Copy Markdown
Contributor Author

bdukes commented Feb 17, 2026

I've also confirmed now that this works as expected when upgrading from DNN 9.13.9

@donker
Copy link
Copy Markdown
Contributor

donker commented Feb 17, 2026

I have confirmed the following scenarios:

  1. Install without wizard
  2. Install with wizard
  3. Upgrade from 10.1.2
  4. Upgrade from 9.13.9

@bdukes bdukes merged commit b8ed596 into dnnsoftware:develop Feb 23, 2026
3 checks passed
@bdukes bdukes deleted the remove-system.memory branch February 23, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Upgrade from 9.13.10 to 10.2.2 results in "Could not load file or assembly 'System.Memory' or one of its dependencies."

3 participants