Add source for DotNetNuke.WebControls#6988
Merged
donker merged 24 commits intodnnsoftware:developfrom Feb 17, 2026
Merged
Conversation
7e01a77 to
c30e861
Compare
mitchelsellers
previously requested changes
Feb 14, 2026
Contributor
mitchelsellers
left a comment
There was a problem hiding this comment.
Should these files all have the .NET Foundation Copyright notice?
Use StringBuilder.Append(char) for single character strings
Seal internal types
Do not declare visible instance fields
Instantiate argument exceptions correctly
Use concrete types when possible for improved performance
Do not initialize unnecessarily
Mark attributes with AttributeUsageAttribute
Insecure DTD Processing
Do not raise reserved exception types
Specify StringComparison for correctness
Specify IFormatProvider
CA1861: Avoid constant arrays as arguments This usage seems to be mutating the array passed in
Removed PackageReference for Microsoft.SourceLink.GitHub. I believe this is a global package reference already. In any case it wouldn't build unless I removed this.
c30e861 to
192c03d
Compare
Contributor
Author
Yup, I've added it, thanks! |
valadas
approved these changes
Feb 16, 2026
Contributor
valadas
left a comment
There was a problem hiding this comment.
I have installed the CI build and did a few things add/remove modules, edit settings, etc. Everything appears to be working fine to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DotNetNuke.WebControls has been included with DNN for many years as a DLL, but the source code was missing from the git repository. This PR adds source code back in.