Skip to content

Fix Portal-based CDV version for client resource management#6987

Merged
valadas merged 11 commits intodnnsoftware:developfrom
donker:fix-portal-cdv
Feb 13, 2026
Merged

Fix Portal-based CDV version for client resource management#6987
valadas merged 11 commits intodnnsoftware:developfrom
donker:fix-portal-cdv

Conversation

@donker
Copy link
Copy Markdown
Contributor

@donker donker commented Feb 11, 2026

This PR aims to fix #6946

The new Client Resource Framework that was introduced in 10.2.0 did not include code to allow portals to override the crm version (appended as ?cdv=123 to resource urls). This PR aims to fix that omission and improve the UI at the same time. It:

  1. Adds a column in the UI so that it is now clear what is host-level and what is portal-level CDV management
  2. Improves the explanatory text
  3. Marks as deprecated a number of properties in clientResourceSettings in the Web.Client library
  4. Harmonises the setting that determines if the portal should override the crm settings by (a) removing the double setting and (b) renaming the core setting to one that is in sync with the code.
  5. Adds a new IClientResourcesSettings interface and implementation for DI so the resources controller can access these settings.

Copy link
Copy Markdown
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

…rceController.cs

Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
@jeremy-farrance
Copy link
Copy Markdown
Contributor

Peter, the build worked and I am pretty sure I found and used the right artifacts.

image

But within seconds of opening the site and starting the installer, I got this yellowness.

image

If you try and don't see this, would you please give me some steps/help in getting to the right artifacts for the build of this PR?

@donker
Copy link
Copy Markdown
Contributor Author

donker commented Feb 12, 2026

Ah ... the installer. Rrright. That one has no portal so this new code bombs when trying to determine whether to override the app settings. OK, fix incoming.

@jeremy-farrance
Copy link
Copy Markdown
Contributor

jeremy-farrance commented Feb 12, 2026

Okay, logged in as Host, things look like they work well. I was able to flip between Global override and not, the SITE version appeared, tested a bit, no issues.

The rewrite of the CRM paragraph is really great. It always bugs me when things are only written so the developer in the moment knows what it means. Your new version will hopefully make sense to anyone!

Two issues now, first is minor: The UI feels a little awkward. Would you consider stacking them in just one of the columns? I am sure the blank right column will get taken by something upcoming in v10.02.04 or higher. Or, just put only the big paragraph in the left column and stack the 3 items in the right column: Override toggle, Host Inc, Site Inc. Also, rather than have the Site Inc group disappear, I'd pretty strongly suggest just disabling it instead so its grey'd out but still visible. For new users that will feel more intuitive and self-explanatory-at-a-glance as to how the toggle will work (since the default is off).

Second, this one is more serious... to me. When Override Global CDV is True, I believe a Portal Administrator should be able to increment their SITE VERSION.

If you disagree with that, the rest can be ignored.

If it should be an option, here is what a portal admin sees if he goes to the same panel in the PB. Maybe a future contribution if it doesn't make sense right now?
image

@donker
Copy link
Copy Markdown
Contributor Author

donker commented Feb 12, 2026

Point taken about 1. You can tell I struggled to make things a bit more coherent.

Point 2 opens quite the box of Pandora. Currently none of the server settings are accessible by an admin. The entire controller is locked down. Opening up stuff selectively is possible, of course, but is tricky and can introduce security vulnerabilities. I.e. a high risk intervention. Which I hate.

One way we could address that is to move the portal version increment button to some other place. Both in the UI as well as backend code. But where should it go?

@jeremy-farrance
Copy link
Copy Markdown
Contributor

Agreed. Leave idea 2 for a future discussion or issue, if/when. I double-checked that it was not an option in v9.any

Thanks again for accidentally teaching me how to install a build of a PR! 🙂

@donker
Copy link
Copy Markdown
Contributor Author

donker commented Feb 13, 2026

I've pushed a change to the layout to address the first point. I'm still quite attached to the two column approach so I left that (if we ever need that space we'll cross that bridge when we get there IMHO). But now the right hand is always visible and is just disabled if the switch is off.

@jeremy-farrance
Copy link
Copy Markdown
Contributor

Works!! ✅

Copy link
Copy Markdown
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@valadas valadas merged commit c87a8a2 into dnnsoftware:develop Feb 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

[Bug]: CRM/CDV Cache Busting Stopped working after upgrade to DNN v10.02+

4 participants