Fix Portal-based CDV version for client resource management#6987
Fix Portal-based CDV version for client resource management#6987valadas merged 11 commits intodnnsoftware:developfrom
Conversation
…dicating whether the portal overrides the host for CRM settings. Make the naming consistent. Remove the deprecated values and mark them as deprecated in code.
DNN Platform/DotNetNuke.Web.Client.ResourceManager/ClientResourceController.cs
Outdated
Show resolved
Hide resolved
…rceController.cs Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
|
Ah ... the installer. Rrright. That one has no portal so this new code bombs when trying to determine whether to override the app settings. OK, fix incoming. |
|
Point taken about 1. You can tell I struggled to make things a bit more coherent. Point 2 opens quite the box of Pandora. Currently none of the server settings are accessible by an admin. The entire controller is locked down. Opening up stuff selectively is possible, of course, but is tricky and can introduce security vulnerabilities. I.e. a high risk intervention. Which I hate. One way we could address that is to move the portal version increment button to some other place. Both in the UI as well as backend code. But where should it go? |
|
Agreed. Leave idea 2 for a future discussion or issue, if/when. I double-checked that it was not an option in v9.any Thanks again for accidentally teaching me how to install a build of a PR! 🙂 |
… into fix-portal-cdv
|
I've pushed a change to the layout to address the first point. I'm still quite attached to the two column approach so I left that (if we ever need that space we'll cross that bridge when we get there IMHO). But now the right hand is always visible and is just disabled if the switch is off. |
|
Works!! ✅ |



This PR aims to fix #6946
The new Client Resource Framework that was introduced in 10.2.0 did not include code to allow portals to override the crm version (appended as ?cdv=123 to resource urls). This PR aims to fix that omission and improve the UI at the same time. It: