Made JWT TTL configurable#6920
Merged
valadas merged 1 commit intodnnsoftware:developfrom Jan 18, 2026
Merged
Conversation
JWT implementation had hardcoded values for the session timeout and the renewal timeout. With this PR we can set those values in the web.config instead. I decided to use minutes for both values because: - It is simpler to have the same unit of measure - I needed to do some testing for another project and needed to make those very short just to trigger the bug. The code fallback to the original hardcoded values if the settings don't exist and the initial default settings are put in the web.config for discoverability.
mitchelsellers
approved these changes
Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JWT implementation had hardcoded values for the session timeout and the renewal timeout. With this PR we can set those values in the web.config instead.
I decided to use minutes for both values because:
The code fallback to the original hardcoded values if the settings don't exist and the initial default settings are put in the web.config for discoverability.
Summary