Skip to content

Don't package globbing assembly twice#6845

Merged
donker merged 2 commits intodnnsoftware:developfrom
bdukes:duplicate-globbing-package
Dec 11, 2025
Merged

Don't package globbing assembly twice#6845
donker merged 2 commits intodnnsoftware:developfrom
bdukes:duplicate-globbing-package

Conversation

@bdukes
Copy link
Copy Markdown
Contributor

@bdukes bdukes commented Dec 10, 2025

Summary

The install and upgrade package currently include two copies of the Microsoft.Extensions.FileSystemGlobbing library. This doesn't cause any particular issue, but it would be good to only have one copy of the package.

@bdukes bdukes added this to the 10.2.1 milestone Dec 10, 2025
@valadas
Copy link
Copy Markdown
Contributor

valadas commented Dec 10, 2025

I see but where is it included with this removal?

@bdukes
Copy link
Copy Markdown
Contributor Author

bdukes commented Dec 10, 2025

It's packaged by the PackageMicrosoftGlobbing task, so it didn't need to be in thirdparty.json

@valadas
Copy link
Copy Markdown
Contributor

valadas commented Dec 10, 2025

Oh, I see, great!

@donker donker merged commit 4c5b666 into dnnsoftware:develop Dec 11, 2025
3 checks passed
@bdukes bdukes deleted the duplicate-globbing-package branch December 11, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants