Fix new pages remain in Draft when Versioning is enabled and Workflow is disabled#6836
Merged
valadas merged 7 commits intodnnsoftware:developfrom Dec 23, 2025
Merged
Fix new pages remain in Draft when Versioning is enabled and Workflow is disabled#6836valadas merged 7 commits intodnnsoftware:developfrom
valadas merged 7 commits intodnnsoftware:developfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where new pages remained in Draft status when Versioning was enabled but Workflow was disabled. The fix ensures pages are created with the correct published state for all combinations of Versioning and Workflow settings, particularly addressing the broken case where Versioning=On and Workflow=Off.
Key changes:
- Adds logic to hide workflow menu items (Complete/Discard) when Direct Publish workflow is active, reducing UI confusion
- Refactors workflow information display in PersonaBar to show more accurate state information even when no explicit state is assigned
- Fixes portal ID retrieval in WorkflowHelper to use the tab's portal ID instead of current portal settings
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Dnn.AdminExperience/EditBar/Dnn.EditBar.UI/Items/WorkflowBaseMenuItem.cs | Adds IsDirectPublishWorkflow property to identify when Direct Publish workflow is active |
| Dnn.AdminExperience/EditBar/Dnn.EditBar.UI/Items/DiscardWorkflowMenu.cs | Updates visibility logic to hide discard menu when Direct Publish workflow is active |
| Dnn.AdminExperience/EditBar/Dnn.EditBar.UI/Items/CompleteWorkflowMenu.cs | Updates visibility logic to hide complete menu when Direct Publish workflow is active |
| Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Components/Pages/WorkflowHelper.cs | Fixes potential null reference by using tab's PortalID instead of PortalSettings.Current |
| Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Components/Pages/PagesControllerImpl.cs | Refactors workflow handling to determine StateName and WorkflowName with proper null handling when StateID is not set |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Components/Pages/PagesControllerImpl.cs
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/EditBar/Dnn.EditBar.UI/Items/DiscardWorkflowMenu.cs
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/EditBar/Dnn.EditBar.UI/Items/CompleteWorkflowMenu.cs
Outdated
Show resolved
Hide resolved
Contributor
|
@tvatavuk Can you look at the merge issue here? |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tvatavuk
commented
Dec 23, 2025
Contributor
Author
tvatavuk
left a comment
There was a problem hiding this comment.
merge issue resolved
mitchelsellers
approved these changes
Dec 23, 2025
Contributor
|
@tvatavuk looks like there are a couple of build errors. |
Contributor
Author
Contributor
|
Awesome! Thanks a lot @tvatavuk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6810
Summary
New pages behave correctly for all combinations of Versioning and Workflow settings:
TODO
Specifically, auto-publish pages that were incorrectly created as Draft when: