Fix CDF webforms lifecycle issues#6830
Conversation
mitchelsellers
left a comment
There was a problem hiding this comment.
Just a general question here, do we anticipate this being considered a breaking change in any possibility by changing the processes from OnInit to OnLoad, which is later in the lifecycle?
Could this have a breaking change implication to anyone that may be using this in a custom module or otherwise?
Additionally: There appears to be test failures
|
I am fixing an issue that is causing the current Css/JSExclude to not work as advertised because of the Webforms lifecycle, BTW.
I have asked myself this but have not succeeded in coming up with a scenario where that would happen. You're not supposed to inherit from these controls AFAIK. And given the entire page lifecycle in CDF is going away, it begs the question how it could break something. But if anyone has an idea, I'd be happy to test.
That appeared to be from another commit than this. |
The new CDF detaches itself from the Webforms lifecycle. The old CDF was very much tied into it as it created and deleted controls. The Css/JsExclude controls might miss their effect if this is not taken into account. We ran into an issue where a CSS file was not removed that should have been removed.