Skip to content

Include sample modules#6821

Merged
bdukes merged 22 commits intodnnsoftware:developfrom
donker:include-sample-modules
Dec 2, 2025
Merged

Include sample modules#6821
bdukes merged 22 commits intodnnsoftware:developfrom
donker:include-sample-modules

Conversation

@donker
Copy link
Copy Markdown
Contributor

@donker donker commented Nov 29, 2025

This PR addresses issue #6817

With this PR we include a sample MVC and SPA module in the solution. You can opt to build these to the output using your own local settings:

DNN_Platform.local.build

<Project ToolsVersion="4.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <PropertyGroup>
    <WebsitePath Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">D:\path\to\my\local\dnn\site</WebsitePath>
    <CopySampleProjects>True</CopySampleProjects>
  </PropertyGroup>
</Project>

settings.local.json

{
 ...
  "CopySampleProjects": true,
  "Version": "10.99.0"
}

In debug mode the projects build as any other and the dll gets copied to a destination based on the master switch. In release mode the modules get built to Artifacts/SampleModules.

@valadas
Copy link
Copy Markdown
Contributor

valadas commented Nov 29, 2025

I only had time to take a very quick look, but that looks awesome!
For me on the SPA module I think I would add a couple of .md files just to explain that it is done one way here but could be done with anything one would like (react, angular, ionic, web-components, stencil, vanilla js, typescript, etc.), that jQuery is available upon request but not needed or provided unless requested, a couple of little things like that, that can potentially evolve. But love the samples so far. I'll give those a test hopefully by the end of this weekend

@donker
Copy link
Copy Markdown
Contributor Author

donker commented Nov 29, 2025

I only had time to take a very quick look, but that looks awesome! For me on the SPA module ...

I am somewhat torn on the SPA module. I've spent a couple of hours making it look a bit better than before. This module has a reason to be here and a reason not to be. The reason it should be here is that it shows how far you can take this whole HTML templating stuff. The reason, IMHO, it shouldn't be here is that I don't wish to create the impression how you should use this module pattern. Instead I'd much rather promote a SPA module with a React frontend as that is the way most web UI developers see frontend development. But yeah ... framework wars incoming.

@donker donker added this to the 10.2.0 milestone Dec 1, 2025
Copy link
Copy Markdown
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is ok as it is, however, my only question/comment/thought is to add some sort of a Readme.md or similar to the /Samples directory to show that these are samples and for illustration purposes only.

@bdukes bdukes merged commit 8a925b8 into dnnsoftware:develop Dec 2, 2025
3 checks passed
@donker donker deleted the include-sample-modules branch December 24, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants