Conversation
|
I only had time to take a very quick look, but that looks awesome! |
I am somewhat torn on the SPA module. I've spent a couple of hours making it look a bit better than before. This module has a reason to be here and a reason not to be. The reason it should be here is that it shows how far you can take this whole HTML templating stuff. The reason, IMHO, it shouldn't be here is that I don't wish to create the impression how you should use this module pattern. Instead I'd much rather promote a SPA module with a React frontend as that is the way most web UI developers see frontend development. But yeah ... framework wars incoming. |
mitchelsellers
left a comment
There was a problem hiding this comment.
I believe this is ok as it is, however, my only question/comment/thought is to add some sort of a Readme.md or similar to the /Samples directory to show that these are samples and for illustration purposes only.
This PR addresses issue #6817
With this PR we include a sample MVC and SPA module in the solution. You can opt to build these to the output using your own local settings:
DNN_Platform.local.build
settings.local.json
In debug mode the projects build as any other and the dll gets copied to a destination based on the master switch. In release mode the modules get built to Artifacts/SampleModules.