Corrected requestLengthDiskThreshold to use MS default of 80#6819
Merged
valadas merged 1 commit intodnnsoftware:developfrom Nov 28, 2025
Merged
Conversation
valadas
approved these changes
Nov 28, 2025
Contributor
valadas
left a comment
There was a problem hiding this comment.
Great, I'll tag this as noteworthy to potentially add some notes about it in release notes
mitchelsellers
approved these changes
Nov 28, 2025
Contributor
mitchelsellers
left a comment
There was a problem hiding this comment.
This looks good to me!
Contributor
Author
|
On a fresh install of this build, the desired behavior seems to check out. 
|
Contributor
Author
|
Because of the build resulting in 10.01.03, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #6816
As mentioned in the above issue comments, the MS documentation is wrong. A PR has been submitted by @mitchelsellers to correct the MS documentation. This PR changes the
requestLengthDiskThresholdvalue back to80(which means 80KB). The way it was prior, nothing would ever get written to disk (no chunking) because the value was actually 80MB due to the incorrect documented unit for this attribute. Instead uploads would be held in memory until the full upload is complete and then written to disk at the end. This change will allow 80KB chunks to be written to disk during the uploads (freeing up memory).Our suspicion is this has caused quite a few issues lately with module installations close to 28MB (e.g., 24MB) running out of memory and preventing installation. Also, upgrades in Azure seem to be experiencing similar issues.