Remove FromSrc in the new CDF solution in favor of CreateX method.#6812
Merged
valadas merged 2 commits intodnnsoftware:developfrom Nov 22, 2025
Merged
Remove FromSrc in the new CDF solution in favor of CreateX method.#6812valadas merged 2 commits intodnnsoftware:developfrom
valadas merged 2 commits intodnnsoftware:developfrom
Conversation
bdukes
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After feedback from developers adjusting old code, I propose to shorten
to
After all, the source is required in both all script elements as well as all link elements. So there is no use case where FromSrc would not be used.