Skip to content

Remove FromSrc in the new CDF solution in favor of CreateX method.#6812

Merged
valadas merged 2 commits intodnnsoftware:developfrom
donker:cdf-remove-fromsrc
Nov 22, 2025
Merged

Remove FromSrc in the new CDF solution in favor of CreateX method.#6812
valadas merged 2 commits intodnnsoftware:developfrom
donker:cdf-remove-fromsrc

Conversation

@donker
Copy link
Copy Markdown
Contributor

@donker donker commented Nov 21, 2025

After feedback from developers adjusting old code, I propose to shorten

 clientResourcesController.CreateScript().FromSrc("path/to/script.js").Register();

to

 clientResourcesController.CreateScript("path/to/script.js").Register();

After all, the source is required in both all script elements as well as all link elements. So there is no use case where FromSrc would not be used.

Copy link
Copy Markdown
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it

@valadas valadas merged commit bb57930 into dnnsoftware:develop Nov 22, 2025
3 checks passed
@donker donker deleted the cdf-remove-fromsrc branch February 4, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants