Merged
Conversation
…classes to include all the required methods.
…l. Fix issues with new CRM.
… are in the web.config of existing sites.
…rceController.cs Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
…rceController.cs Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
…rocessingProvider.cs Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
…urceBase.cs Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
…ptResource.cs Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
…Resource.cs Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
…esheetResource.cs Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
…urceBase.cs Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Using case-insensitive comparisons makes it unnecessary
Contributor
|
@donker I've adjusted a few other places, including the version comparison. This is ready from my perspective. |
mitchelsellers
approved these changes
Nov 5, 2025
Contributor
mitchelsellers
left a comment
There was a problem hiding this comment.
I did one additional WebForms test and all still good
Contributor
|
@valadas or @david-poindexter Can I get a review from one of you on this one, since Brian made the last edits |
valadas
reviewed
Nov 7, 2025
bdukes
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will move DNN away from the ClientDependencyCore project and replace this with our own (simplified) logic for managing client dependencies.
Motivation
We do this for two main reasons:
Overview of Changes
The main changes are in the System.Web.Client library that managed most interaction with the CDF. The central class ClientDependencyManager now reroutes calls to the new logic and has been marked as deprecated. The new logic is concentrated in System.Web.Client.ResourceManagement and consists of an injectable IClientResourceController. This controller is used as follows to add a resource:
It is important to call
Register()at the end to add the resource. Various extension methods allow you to specify specific attributes to be added for the resource such as async and defer. There are also shorthand extensions in the DotNetNukelIbrary project to register a script with defaults:this.clientResourcesController.RegisterScript("~/Resources/Search/Search.js");Breaking Changes
Note that this PR removes the ability to minify and bundle from the framework. Our motivation to cut support for this is:
This PR addresses #6643