Skip to content

Fix cacheability settings#6711

Merged
bdukes merged 3 commits intodnnsoftware:developfrom
donker:fix-c2
Sep 17, 2025
Merged

Fix cacheability settings#6711
bdukes merged 3 commits intodnnsoftware:developfrom
donker:fix-c2

Conversation

@donker
Copy link
Copy Markdown
Contributor

@donker donker commented Sep 17, 2025

The mechanism to get and update the cacheability settings had a bug which prevented them from properly getting used.

This PR should fix #6703

Copy link
Copy Markdown
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@bdukes bdukes enabled auto-merge (rebase) September 17, 2025 19:25
@valadas
Copy link
Copy Markdown
Contributor

valadas commented Sep 17, 2025

I tested:

  • Clean v9.13.9 (ServerAndNoCache was default) it migrated fine and kept ServerAndNoCache for the value.
  • Clean v10.1.0 install (default to 4 which meant ServerAndNoCache but UI was broken), upgraded to this build, migrated fine to ServerAndNoCache and UI is fixed.
  • Clean install of this build, works fine but defaults to 4 in the database, so when visiting the persona bar, nothing appears to be selected. I think we need to hunt down where that out-of-the-box default gets set and have a current value on a new install for this version or future ones... I'll see if I can find that...

@valadas
Copy link
Copy Markdown
Contributor

valadas commented Sep 17, 2025

This commit changes the default to match the new way to store them 29eae34

Copy link
Copy Markdown
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I tested the default now works with last commit. Merging

@bdukes bdukes merged commit 18e4683 into dnnsoftware:develop Sep 17, 2025
3 checks passed
@valadas
Copy link
Copy Markdown
Contributor

valadas commented Sep 17, 2025

Oh, @bdukes was faster than me ;)

@bdukes
Copy link
Copy Markdown
Contributor

bdukes commented Sep 18, 2025

Oh, @bdukes was faster than me ;)

The magic of auto-merge 🪄

@donker donker deleted the fix-c2 branch February 4, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

[Bug]: Output Caching UI completely wrong in DNN 10

3 participants