Cleaned React.Common exposed react components that were marked for v10 removal#6684
Merged
bdukes merged 1 commit intodnnsoftware:developfrom Sep 5, 2025
Merged
Conversation
…0 removal 5 years ago Matt and me (and few others) did a massive cleanup of the react common components after the react upgrade debacle. At that time we marked that some components should no longer be exposed in the bundle directly. This was missed when we created v10.0.0 This PR removes those. The bundle size reduced from 2303kB to 1647Kb (compressed from 754kB to 354kB). I have visited each persona bar module and clicked around different tabs and pickers, etc. and did not notice anything broken.
mitchelsellers
approved these changes
Sep 5, 2025
bdukes
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5 years ago Matt and me (and few others) did a massive cleanup of the react common components after the react upgrade debacle. At that time we marked that some components should no longer be exposed in the bundle directly. This was missed when we created v10.0.0
This PR removes those. The bundle size reduced from 2303kB to 1647Kb (compressed from 754kB to 354kB).
I have visited each persona bar module and clicked around different tabs and pickers, etc. and did not notice anything broken.