Fix: #5696, Do not convert unicode chars in filenames#6654
Merged
bdukes merged 3 commits intodnnsoftware:developfrom Aug 19, 2025
Merged
Fix: #5696, Do not convert unicode chars in filenames#6654bdukes merged 3 commits intodnnsoftware:developfrom
bdukes merged 3 commits intodnnsoftware:developfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
Author
|
Hello, I noticed that I don't have the permissions to set the Milestone and Labels for this pull request. Could you please add the following:
Thank you for your help. |
bdukes
approved these changes
Aug 13, 2025
mitchelsellers
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5696
Summary
This pull request addresses the issue of file uploads failing when filenames contain Unicode characters, such as Farsi or Arabic.
The previous implementation used
Utility.ConvertUnicodeChars, which incorrectly removed these characters from the filename, leading to upload failures.This change replaces that flawed logic with a safer and more robust method:
Path.GetInvalidFileNameChars()from the .NET framework.This approach ensures that filenames with non-English characters are properly preserved while maintaining security against potential path traversal attacks. The fix is a direct and efficient solution that doesn't introduce any new dependencies.