Clean up legacy code#6620
Merged
mitchelsellers merged 1 commit intodnnsoftware:developfrom Jul 15, 2025
Merged
Conversation
bdukes
approved these changes
Jul 15, 2025
Contributor
|
I agree, I don't see the utility of this being in its own project. |
mitchelsellers
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems we are not doing multitargeting and the NETFRAMEWORK directive can sometimes lead to code being erroneously marked as absent when it is not.
This also begs the question whether we really need this library in the project and if we should move the code back in, IMHO.