Remove implicit dependencies in PortalController#6602
Merged
valadas merged 4 commits intodnnsoftware:developfrom Jul 9, 2025
Merged
Remove implicit dependencies in PortalController#6602valadas merged 4 commits intodnnsoftware:developfrom
valadas merged 4 commits intodnnsoftware:developfrom
Conversation
316a4aa to
d10fdec
Compare
Contributor
Author
|
Build is green now (apparently there were a couple of projects that didn't include all of the warnings when building in the Debug configuration, so I didn't see the errors locally) |
valadas
reviewed
Jun 30, 2025
Contributor
valadas
left a comment
There was a problem hiding this comment.
I'll need to come back to finish my review, but overall I am just curious if there is a good reason to do so much method parameter injection instead of constructor injection.
81dc493 to
9579d49
Compare
mitchelsellers
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes usages of
InstanceinPortalController