Resolve warnings in DotNetNuke.HttpModules & fix DI timing#6591
Merged
david-poindexter merged 3 commits intodnnsoftware:developfrom Jun 12, 2025
Merged
Resolve warnings in DotNetNuke.HttpModules & fix DI timing#6591david-poindexter merged 3 commits intodnnsoftware:developfrom
david-poindexter merged 3 commits intodnnsoftware:developfrom
Conversation
valadas
reviewed
Jun 12, 2025
180f426 to
0e01858
Compare
This allows DI to be available on first run when initializing IHttpModule instances
0e01858 to
fdea035
Compare
david-poindexter
approved these changes
Jun 12, 2025
Contributor
david-poindexter
left a comment
There was a problem hiding this comment.
Thank you @bdukes 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves all warnings in the DotNetNuke.HttpModules project.
Noteworthy changes
Since HTTP Modules are initialized very early in the process of starting the application, the DI container was not ready to inject constructor parameters. The first commit in this PR moves the DI initialization code from the
Application_Starthandler to the static constructor of the application class. This appears to fix the issue, making constructor injection work in all components.