Added eslint to resource-manager project and updated dnn-elements to latest#6555
Merged
bdukes merged 10 commits intodnnsoftware:developfrom Jul 8, 2025
Merged
Added eslint to resource-manager project and updated dnn-elements to latest#6555bdukes merged 10 commits intodnnsoftware:developfrom
bdukes merged 10 commits intodnnsoftware:developfrom
Conversation
bdukes
approved these changes
May 20, 2025
...ResourceManager/ResourceManager.Web/src/components/dnn-rm-actions-bar/dnn-rm-actions-bar.tsx
Show resolved
Hide resolved
DNN Platform/Modules/ResourceManager/Services/ItemsController.cs
Outdated
Show resolved
Hide resolved
eslint/utils was missing from peerDependencies which cause some consuming project builds to fail
Contributor
|
@valadas Can you fix the merge issues on this one? |
Contributor
Author
|
@mitchelsellers rebased |
Contributor
Author
|
@mitchelsellers @donker I just rebased if you can review/merge when built... |
Contributor
Author
|
Aiight @dnnsoftware/approvers re-re-re-based |
mitchelsellers
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In https://github.com/DNNCommunity/dnn-elements/tree/develop/packages/stencil-library/eslint-plugin I implemented our own eslint plugin that will help manage future deprecations/best-practices regarding dnn-elements.
This PR adds eslint to the resource-manager project and then updated dnn-elements to the latest and uses those rules. I also refactored a lot of code from using Promises to use async/await which is much more readable and understandable.