Remove obsolete usages in DotNetNuke.Website#6535
Merged
bdukes merged 5 commits intodnnsoftware:developfrom May 2, 2025
Merged
Remove obsolete usages in DotNetNuke.Website#6535bdukes merged 5 commits intodnnsoftware:developfrom
bdukes merged 5 commits intodnnsoftware:developfrom
Conversation
Obsolete member 'memberA' overrides non-obsolete member 'memberB'. Remove DnnDeprecated attributes from methods within classes that are deprecated (they're already deprecated at the class level).
Argument type is not CLS-compliant
Identifier 'identifier' differing only in case is not CLS-compliant In cases where the duplicate member is deprecated and planned to be removed, disable the warnings with #pragma statements. Rename the Dnn.PersonaBar.Library.DTO namespace to Dnn.PersonaBar.Library.Dto
Identifier beginning with an underscore is not CLS-compliant
Remove the "user online" indicator from the Manage Users and Membership controls. Mark the admin/Sales PayPal integration pages & control as deprecated I did not yet change calls to PortalSecurity.InputFilter for usernames and things like that, instead suppressing those warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves and treats as errors the following warnings:
Notable changes
Remove the "user online" indicator from the Manage Users and Membership controls.
Mark the admin/Sales PayPal integration pages & control as deprecated
I did not yet change calls to PortalSecurity.InputFilter for usernames and things like that, instead suppressing those warnings.