Skip to content

Remove obsolete types#6523

Merged
valadas merged 1 commit intodnnsoftware:release/10.0.1from
bdukes:remove-obsolete-types
Apr 30, 2025
Merged

Remove obsolete types#6523
valadas merged 1 commit intodnnsoftware:release/10.0.1from
bdukes:remove-obsolete-types

Conversation

@bdukes
Copy link
Copy Markdown
Contributor

@bdukes bdukes commented Apr 28, 2025

Summary

There were a couple of methods marked to be removed in DNN 10 that did not get removed. Do we want to get those in DNN 10.0.1?

@bdukes bdukes added this to the 10.0.1 milestone Apr 28, 2025
@bdukes bdukes force-pushed the remove-obsolete-types branch from 6b70c37 to 3844179 Compare April 28, 2025 19:18
valadas
valadas approved these changes Apr 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not opposed to those removals

mitchelsellers
mitchelsellers approved these changes Apr 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I too am ok with this! Good catch @bdukes

@bdukes
Copy link
Copy Markdown
Contributor Author

bdukes commented Apr 29, 2025

The ProviderConfigurationHandler says it is was deprecated in DNN 7 and is no longer used, but it's still used for all of the custom config sections in the web.config (hence the test errors).

Dnn.Platform/DNN Platform/Library/Framework/Providers/ProviderConfigurationHandler.cs

Lines 4 to 21 in 14755c2

namespace DotNetNuke.Framework.Providers
{
using System.Configuration;
using System.Xml;
using DotNetNuke.Internal.SourceGenerators;
[DnnDeprecated(7, 0, 0, "It is no longer used to load provider configurations, as there are medium trust issues", RemovalVersion = 10)]
internal partial class ProviderConfigurationHandler : IConfigurationSectionHandler
{
/// <inheritdoc/>
public virtual object Create(object parent, object context, XmlNode node)
{
var objProviderConfiguration = new ProviderConfiguration();
objProviderConfiguration.LoadValuesFromConfigurationXml(node);
return objProviderConfiguration;
}
}

@dnnsoftware/approvers does anyone know anything about issues with this class or how we would replace it? I'm going to remove it from this PR for now.

@bdukes bdukes force-pushed the remove-obsolete-types branch from 3844179 to 8c7c95c Compare April 29, 2025 14:36
@bdukes bdukes force-pushed the remove-obsolete-types branch from 8c7c95c to ffbd61d Compare April 29, 2025 15:02
@valadas valadas merged commit e1f7d3c into dnnsoftware:release/10.0.1 Apr 30, 2025
3 checks passed
@bdukes bdukes deleted the remove-obsolete-types branch April 30, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mitchelsellers mitchelsellers mitchelsellers approved these changes

@valadas valadas valadas approved these changes

Assignees

No one assigned

Labels

Alert: Breaking Change Type: Maintenance

Projects

None yet

Milestone

10.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@bdukes @mitchelsellers @valadas