Prevents Roslyn Compilation Errors During DNN v10 Upgrade#6452
Prevents Roslyn Compilation Errors During DNN v10 Upgrade#6452valadas merged 1 commit intodnnsoftware:release/10.0.0from
Conversation
valadas
left a comment
There was a problem hiding this comment.
Whoaaa, that is an interesting idea, the packaging install then puts this back I assume right?
bdukes
left a comment
There was a problem hiding this comment.
I'm fine with this, since it sounds like it resolved your issues in comparison to other approaches you tried.
It seems like this could happen during a regular upgrade of the Roslyn package, not just during a DNN upgrade. How reliably are you seeing the error condition? I wasn't able to reproduce with a couple of attempts.
I encountered a compilation error in approximately 80% of my tests under the following scenario:
This issue appeared consistently across multiple test runs, making it a highly reproducible scenario in environments with several 2sxc content and app instances before the upgrade to 10.0.0. |
|
First, thank you for reviewing and merging this PR. Since this fix initially removed already installed parts of the extension in Because of this, I continued searching for a better solution. The latest version of the fix is now self-contained in the most logical place— This fix effectively uninstalls Roslyn by:
I verified the fix with multiple test scenarios, all of which executed several times without issues:
Since all tests were successful, I believe the best course of action is to create a new PR with this improved fix. |
Fixes #6448
Summary
Prevents Roslyn from running to avoid potential compilation errors when a newer version of Roslyn is installed in the next steps with
Microsoft.CodeDom.Providers.DotNetCompilerPlatform_04.01.00_Install.zip.