Fix two tab deletion issues#6446
Merged
donker merged 4 commits intodnnsoftware:developfrom Mar 25, 2025
Merged
Conversation
valadas
reviewed
Mar 12, 2025
Contributor
valadas
left a comment
There was a problem hiding this comment.
Is HardDeleteTabInternal ok here in the context ? Does that skip the recycle bin ?
Contributor
Author
Yes, this is all hard deleting. The Dnn.Platform/DNN Platform/Library/Entities/Tabs/TabController.cs Lines 1191 to 1206 in cfed83c So this is just removing the check for children tabs, since it just took care of them. |
valadas
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two bugs with deleting tabs. The first is described in #6438. The second comes when calling
DeleteTabon a tab that has already been deleted (perhaps related to a workaround for the first issue 😉).Fixes #6438