Skip to content

Fixed an issue managing folder permissions#6440

Merged
valadas merged 2 commits intodnnsoftware:developfrom
schotman:develop
Mar 11, 2025
Merged

Fixed an issue managing folder permissions#6440
valadas merged 2 commits intodnnsoftware:developfrom
schotman:develop

Conversation

@schotman
Copy link
Copy Markdown
Contributor

@schotman schotman commented Mar 11, 2025

Solve permission problems as reported in
Closes #6391
Closes #6318

Summary

this.lastPermissions?.rolePermissions?.find(p => p.roleId === rolePermission.roleId).permissions

the find returns an undefined for newly added roles (and users) to the permission grid, therefore the .permissions crashes and subsequent failures follow.

Solve permission problems as reported in
#6391 and #6318
Copy link
Copy Markdown
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@valadas valadas changed the title Fixes #6391 and #6318 Fixed an issue managing folder permissions Mar 11, 2025
@bdukes bdukes added this to the 9.13.9 milestone Mar 11, 2025
@valadas valadas modified the milestones: 9.13.9, 9.14.0 Mar 11, 2025
@valadas valadas merged commit 161e540 into dnnsoftware:develop Mar 11, 2025
3 checks passed
@jeremy-farrance
Copy link
Copy Markdown
Contributor

This also successfully closes Issue #5847 from Nov 2023. @schotman, I don't think that I can thank you enough. Within an hour of you posting this fix, one of my clients stopped by the office to let me know that this had finally been addressed! Thank you !!!

If there were an award to a 1-character-code fix, you'd easily win for 2025!!

@schotman
Copy link
Copy Markdown
Contributor Author

@jeremy-farrance
getting my (front-end) dev env in a working state was the most difficult part.

@jeremy-farrance
Copy link
Copy Markdown
Contributor

@jeremy-farrance getting my (front-end) dev env in a working state was the most difficult part.

I put a lot of effort into that recently and took a lot of notes to help other staff at our office. If you have anything to add or correct in the section titled, How to Change and Rebuild PersonaBar Components, please let me know!
Accuraty DNN Development Setup Notes

@bdukes
Copy link
Copy Markdown
Contributor

bdukes commented Apr 25, 2025

@valadas you marked this PR for 9.14.0, but it looks like it was included in 9.13.9 and 10.0.0, does that seem right to you?

@valadas valadas modified the milestones: 9.14.0, 9.13.9 Apr 25, 2025
@valadas
Copy link
Copy Markdown
Contributor

valadas commented Apr 25, 2025

You are correct, just changed it but I have 17 others to check up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: High Urgency: Cannot set anymore folder permissions except for All users and Registered users [Bug]: DNN Resource Manager Permissions Broken

4 participants