Fixed a thumbnail issue for sites not in standard path#6264
Merged
bdukes merged 2 commits intodnnsoftware:developfrom Dec 11, 2024
Merged
Fixed a thumbnail issue for sites not in standard path#6264bdukes merged 2 commits intodnnsoftware:developfrom
bdukes merged 2 commits intodnnsoftware:developfrom
Conversation
valadas
reviewed
Dec 11, 2024
Contributor
valadas
left a comment
There was a problem hiding this comment.
Thanks @thienvc I have set a more descriptive title and a description to the PR.
The logic looks good to me, but we usually don't put references to issues in the source code or leave commented out code. Could you please remove those.
Contributor
Author
Ok, wait for me |
…eir thumbnail properly. Fixes dnnsoftware#6263
valadas
approved these changes
Dec 11, 2024
Contributor
valadas
left a comment
There was a problem hiding this comment.
Thanks, looks good to me
bdukes
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where sites on non-standard paths would not display their thumbnail properly.
Fixes #6263
Summary