Deprecate DnnLogger#6240
Merged
david-poindexter merged 4 commits intodnnsoftware:developfrom Dec 6, 2024
Merged
Conversation
bdukes
approved these changes
Dec 6, 2024
mitchelsellers
approved these changes
Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we wish to move away from Log4net in the future we must begin to eliminate any exposure of its classes through our API.
The DnnLogger class inherits from and exposes log4net classes. We have an alternative in LoggerSource. Deprecating this now means we can remove log4net if needed by DNN 11.