Make GitVersion config less ambiguous#6195
Merged
valadas merged 1 commit intodnnsoftware:developfrom Nov 6, 2024
Merged
Conversation
david-poindexter
approved these changes
Nov 5, 2024
Contributor
david-poindexter
left a comment
There was a problem hiding this comment.
Looks good to me - thanks @bdukes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some of our builds have failed due to Cake being unable to parse the GitVersion output. Running locally with Diagnostic verbosity, I receive the following error message at the top of the output:
I've deleted any branches that I can see with both
developandreleasein the name for the short-term.This PR updates the
regexfield for the branches to include^(starts with) and$(ends with) tokens, so that the match is exact (i.e. thedeveloprule only matches thedevelopbranch, not other branches that havedevelopin the name).