Update PersonaBar Manage/Roles to show Role ID#6154
Merged
david-poindexter merged 2 commits intodnnsoftware:developfrom Oct 5, 2024
Merged
Conversation
valadas
reviewed
Oct 5, 2024
Contributor
valadas
left a comment
There was a problem hiding this comment.
Looks good but:
- Could it maybe not be bolder than the reset, it stands out a bit much IMO.
- The added props already existed but were not typed I guess, so it fixes warnings ?
Removed bolder from label.
Contributor
Author
Agree on 1, updated/removed bolder from the label. For 2, yes, left them in because it was nice to see it compile with no warnings! :) |
valadas
approved these changes
Oct 5, 2024
Contributor
valadas
left a comment
There was a problem hiding this comment.
Awesome, thanks for the quick turnaround
david-poindexter
approved these changes
Oct 5, 2024
Contributor
david-poindexter
left a comment
There was a problem hiding this comment.
Looks good to me - thank you @jeremy-farrance 🎉
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #6153
[Enhancement]: PersonaBar, Manage Roles - Add Role ID to Visible Information
This screenshot shows the result of these changes.
