Completely remove the ability to edit another user from control.#5971
Merged
valadas merged 1 commit intodnnsoftware:developfrom Feb 15, 2024
Merged
Completely remove the ability to edit another user from control.#5971valadas merged 1 commit intodnnsoftware:developfrom
valadas merged 1 commit intodnnsoftware:developfrom
Conversation
bdukes
approved these changes
Feb 15, 2024
david-poindexter
approved these changes
Feb 15, 2024
Contributor
david-poindexter
left a comment
There was a problem hiding this comment.
I did not have time to test this yet, but it looks good from a browser review perspective. I will not merge it to allow for testing if others want or feel the need to.
mitchelsellers
approved these changes
Feb 15, 2024
valadas
approved these changes
Feb 15, 2024
Contributor
valadas
left a comment
There was a problem hiding this comment.
Gave it a test too and everythhign appears to be working to me.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The EditUser control used to be used to edit users in a (now defunct) module in DNN pre PersonaBar. Currently it is only used to edit one's details when you click on Edit on your profile page. It no longer needs the ability to edit another user and this should be disabled.