Resources manager module: added file open commands#5899
Merged
david-poindexter merged 3 commits intodnnsoftware:developfrom Dec 30, 2023
Merged
Conversation
…bar and single file context menu. Need to replace the Open button with a file link.
Contributor
Author
|
@microsoft-github-policy-service agree company="Aricie Conseil" |
valadas
approved these changes
Dec 30, 2023
Contributor
valadas
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks
...ger/ResourceManager.Web/src/components/actions/dnn-action-open-file/dnn-action-open-file.tsx
Outdated
Show resolved
Hide resolved
david-poindexter
approved these changes
Dec 30, 2023
Contributor
david-poindexter
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for the contribution @stetard 🎉
I'll wait to merge to see if we can get that unnecessary constructor removed.
...ger/ResourceManager.Web/src/components/actions/dnn-action-open-file/dnn-action-open-file.tsx
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5885
Summary
Open commands added for files: double click handler, new button in the action bar and a new context menu for the files.