Merged
Conversation
|
Hey @bdukes, this is amazing, thanks so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As demonstrated in #5858, the Cake build does not work when Yarn has not been installed. The recommended way to install Yarn is via Corepack, which is included with Node.js since version 16.9.0.
Corepack will read the
packageManagerfield frompackage.jsonto determine the correct package manager and its version, and get a copy dynamically, instead of using the JS file checked into the repository.This PR updates the build task which runs Yarn commands to do so via Corepack, to avoid an extra install step. It also adds a check for Corepack and fails the build if it is not available.