Fixed an issue where control characters were allowed in usernames#5835
Merged
mitchelsellers merged 4 commits intodnnsoftware:developfrom Oct 10, 2023
Merged
Fixed an issue where control characters were allowed in usernames#5835mitchelsellers merged 4 commits intodnnsoftware:developfrom
mitchelsellers merged 4 commits intodnnsoftware:developfrom
Conversation
bdukes
reviewed
Oct 9, 2023
mitchelsellers
approved these changes
Oct 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5834
Summary
Prevents control characters to be inserted in the username field.
Before (http://localhost/Login?username=User%00name):
After (http://localhost/Login?username=User%00name):
Noteworthy, this blocks all control characters, including
\nor\r. Instead of removing\tI've added a replacement of a space, but I don't think anyone uses a tab (since this switches the input field in the browser) or new lines (since this isn't a textarea) in their username.