Improved caching in multiple areas#5822
Merged
valadas merged 4 commits intodnnsoftware:developfrom Oct 13, 2023
Merged
Conversation
In practice, this would only happen when requesting a tab for another portal than the one it's in, but using an external cache we have seen this a lot and this fix prevent a lot of unnecessary ClearCache calls.
mitchelsellers
approved these changes
Sep 22, 2023
Contributor
mitchelsellers
left a comment
There was a problem hiding this comment.
This looks good to me!
valadas
requested changes
Sep 22, 2023
DNN Platform/Modules/HTML/Components/WorkflowStateController.cs
Outdated
Show resolved
Hide resolved
DNN Platform/Modules/HTML/Components/WorkflowStateController.cs
Outdated
Show resolved
Hide resolved
bdukes
reviewed
Sep 25, 2023
bdukes
approved these changes
Oct 13, 2023
Contributor
|
@valadas can we get another review from you to clear the requested changes review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR relats to #5819 and covers the caching-related changes: