resourceManager bad url using Azure#5817
Merged
valadas merged 5 commits intodnnsoftware:release/9.13.0from Sep 20, 2023
Merged
Conversation
Update bug-report.yml to include v9.13-rc
fix: resourceManager copyUrl
Contributor
Author
|
@microsoft-github-policy-service agree |
bdukes
reviewed
Sep 20, 2023
...nager/ResourceManager.Web/src/components/actions/dnn-action-copy-url/dnn-action-copy-url.tsx
Outdated
Show resolved
Hide resolved
david-poindexter
approved these changes
Sep 20, 2023
Contributor
david-poindexter
left a comment
There was a problem hiding this comment.
This fix looks good to me. Thanks for the contribution @PabloSR06 🎉
@dnnsoftware/approvers I recommend we go ahead and change this one to target release/9.13.0 so it will be included in this release. Then we can merge release/9.13.0 back into develop. Thoughts?
mitchelsellers
approved these changes
Sep 20, 2023
valadas
approved these changes
Sep 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5797
Summary
Add check before copying the url of a file because if the file is in an azure storage account you will get the url of the page and the storage together