Fixed multiple settings issues in CKEditor Provider#5813
Merged
mitchelsellers merged 5 commits intodnnsoftware:developfrom Oct 10, 2023
Merged
Fixed multiple settings issues in CKEditor Provider#5813mitchelsellers merged 5 commits intodnnsoftware:developfrom
mitchelsellers merged 5 commits intodnnsoftware:developfrom
Conversation
bdukes
approved these changes
Sep 13, 2023
DNN Platform/Providers/HtmlEditorProviders/DNNConnect.CKE/Constants/SettingConstants.cs
Outdated
Show resolved
Hide resolved
DNN Platform/Providers/HtmlEditorProviders/DNNConnect.CKE/Constants/SettingConstants.cs
Outdated
Show resolved
Hide resolved
mitchelsellers
approved these changes
Sep 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes 2 issues:
Closes #5811
Closes #5812
Summary
for #5811 :
Since I have not been able to find any site with a settingname starting with the host level prefix of DNNCKH#, I changed the host level prefix to be the one that's actually being used: DNNCKP#-1#
For obvious reasons I also changed the occurences of strings DNNCHP# to use SettingConstants.
for #5812 :
I had to move the part that reads the setting value outside of an if-block, and stop it from overriding the host level setting with the site level setting, when set on host level.