Skip to content

Update web.config max upload size defaults, correct backend calcs, and fix validation issue preventing increasing#5807

Merged
valadas merged 2 commits intodnnsoftware:developfrom
david-poindexter:issue-5778
Sep 8, 2023
Merged

Update web.config max upload size defaults, correct backend calcs, and fix validation issue preventing increasing#5807
valadas merged 2 commits intodnnsoftware:developfrom
david-poindexter:issue-5778

Conversation

@david-poindexter
Copy link
Copy Markdown
Contributor

Summary

Resolves #5778

The following was done in this PR:

  • Updated default values for maxRequestLength in development.config and release.config.
  • Added section for IIS7 support of maxAllowedContentLength
<system.webServer>
    <security>
      <requestFiltering>
        <requestLimits maxAllowedContentLength="28672000" />
      </requestFiltering>
    </security>
</system.webServer>
  • Resolved backend calculation issues resulting in confusing values (by default and when saving)
  • Resolved validation issue that was preventing an admin from increasing the Max Upload Size in the UI. Now it validates against the max supported value of 4GB (minus one byte) for IIS.

Lastly, we decided it best to not add a new field in the UI to control requestLengthDiskThreshold. Since this is not something DNN admins would typically know/understand, it is best to leave this to manual web.config changes by server admins wanting to optimize performance for specific scenarios/environments.

Copy link
Copy Markdown
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, just one value is not the "Microsoft default" and is quite big here

Copy link
Copy Markdown
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@valadas valadas merged commit 7c9c29f into dnnsoftware:develop Sep 8, 2023
@david-poindexter david-poindexter deleted the issue-5778 branch September 8, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Setting the Max Upload Size (MB) results in unexpected web.config values for requestLengthDiskThreshold

3 participants