Update web.config max upload size defaults, correct backend calcs, and fix validation issue preventing increasing#5807
Merged
valadas merged 2 commits intodnnsoftware:developfrom Sep 8, 2023
Conversation
…d fix validation issue preventing increase
valadas
requested changes
Sep 8, 2023
Contributor
valadas
left a comment
There was a problem hiding this comment.
Awesome, just one value is not the "Microsoft default" and is quite big here
valadas
approved these changes
Sep 8, 2023
bdukes
reviewed
Sep 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #5778
The following was done in this PR:
maxRequestLengthindevelopment.configandrelease.config.maxAllowedContentLengthLastly, we decided it best to not add a new field in the UI to control
requestLengthDiskThreshold. Since this is not something DNN admins would typically know/understand, it is best to leave this to manualweb.configchanges by server admins wanting to optimize performance for specific scenarios/environments.