Fixed an issue where filenames of downloads would get mangled#5806
Merged
david-poindexter merged 2 commits intodnnsoftware:developfrom Sep 8, 2023
Merged
Fixed an issue where filenames of downloads would get mangled#5806david-poindexter merged 2 commits intodnnsoftware:developfrom
david-poindexter merged 2 commits intodnnsoftware:developfrom
Conversation
Closes dnnsoftware#5551 The string is quotes when there are spaces in the filement and Chrome replaced those with underscores. Filenames with special characters are encoded in the response. This adds a function to convert all those special cases back into a plain string that matches the actual filename in the frontend.
bdukes
approved these changes
Sep 8, 2023
david-poindexter
approved these changes
Sep 8, 2023
Contributor
david-poindexter
left a comment
There was a problem hiding this comment.
Awesome @valadas - thanks! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5551
The string is in quotes when there are spaces in the filename and Chrome replaced those with underscores. Filenames with special characters are encoded in the response. This adds a function to convert all those special cases back into a plain string that matches the actual filename in the front end.
Summary