Fixed an issue where users module would not show user picture#5692
Merged
valadas merged 1 commit intodnnsoftware:release/9.12.0from Jun 15, 2023
Merged
Fixed an issue where users module would not show user picture#5692valadas merged 1 commit intodnnsoftware:release/9.12.0from
valadas merged 1 commit intodnnsoftware:release/9.12.0from
Conversation
dnnsoftware#5630 Fixed a backend issue for a feature that was not available on Platform. This PR adds that display into the Users module Additionally `Updates versions as per release candidate creation` github action stopped working somehow (I'll take a look into this) so running a build here caused all those versions to update too. And finally `--colors` was removed from all the `watch` tasks as that option is no longer available in Webpack 5.
bdukes
approved these changes
Jun 15, 2023
Contributor
|
Is this a regression? |
Contributor
Author
Yes and No, I was under the assumption that #5630 was a bugfix for a feature that was existing in the frontend. But it ends up it is an addition and the screenshots in that PR did not come from a Platform install. So the release notes indicate this as a bugfix but users would have been surprised that this was not working on Platform. So I implemented the missing frontend part to complete that. |
mitchelsellers
approved these changes
Jun 15, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5630 Fixed a backend issue for a feature that was not available on Platform. This PR adds that display into the Users module
Additionally
Updates versions as per release candidate creationgithub action stopped working somehow (I'll take a look into this) so running a build here caused all those versions to update too.And finally
--colorswas removed from all thewatchtasks as that option is no longer available in Webpack 5.