Fixed an issue that prevented uploading images using the HTML Editor#5656
Merged
david-poindexter merged 2 commits intodnnsoftware:developfrom Jun 13, 2023
Conversation
bdukes
approved these changes
Jun 7, 2023
DNN Platform/Providers/HtmlEditorProviders/DNNConnect.CKE/Browser/Browser.aspx.cs
Outdated
Show resolved
Hide resolved
…ser/Browser.aspx.cs Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
david-poindexter
approved these changes
Jun 13, 2023
Contributor
david-poindexter
left a comment
There was a problem hiding this comment.
Thanks @skamphuis 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a fix for #5645.
The previous fix for drag/drop of images (#5415 ) broke the upload via the dialog. This fix makes sure both uploads are working as expected.
The upload-request coming from Drag/drop contains a querystring variable "responseType" which I'm using here to determine which response to send.