Deprecated CreateObject calls without IServiceProvider#5604
Merged
mitchelsellers merged 2 commits intodnnsoftware:developfrom Apr 11, 2023
Merged
Deprecated CreateObject calls without IServiceProvider#5604mitchelsellers merged 2 commits intodnnsoftware:developfrom
mitchelsellers merged 2 commits intodnnsoftware:developfrom
Conversation
valadas
approved these changes
Apr 4, 2023
Contributor
valadas
left a comment
There was a problem hiding this comment.
That is an awesome creative idea!
Contributor
|
@bdukes do the test failures on FIPS sound a a fluke to you or is that some sort of clue for a possible bug here ? |
Contributor
Author
|
The tests needed a dependency provider setup now, they should be fixed |
Contributor
Author
|
@mitchelsellers once this is merged, I have a handful of PRs that make use of these changes |
mitchelsellers
approved these changes
Apr 11, 2023
Contributor
|
@bdukes Awesome work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds overloads to
Reflection.CreateObjectwhich takeIServiceProviderso that services can be injected.