Skip to content

Bumped webpack to v5#5570

Merged
bdukes merged 4 commits intodnnsoftware:developfrom
valadas:webpack-upgrade5
Mar 13, 2023
Merged

Bumped webpack to v5#5570
bdukes merged 4 commits intodnnsoftware:developfrom
valadas:webpack-upgrade5

Conversation

@valadas
Copy link
Copy Markdown
Contributor

@valadas valadas commented Mar 12, 2023

Bumped webpack to v5

This removes the workarounds put in place in 9.11.1 so the build works in CI where node was upgrade to v18. Our build should now work on node 16 and 18 without workaround in place... Hopefully.

I tested a full build and confirmed all the modules still load up fine.

@valadas valadas added this to the 9.11.2 milestone Mar 12, 2023
@valadas
Copy link
Copy Markdown
Contributor Author

valadas commented Mar 12, 2023

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Mar 12, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@valadas
Copy link
Copy Markdown
Contributor Author

valadas commented Mar 12, 2023

I don't get it, the build error has nothing to do with these changes... @bdukes do you have any clue about the binlog version (assuming that is the problem here)...

@valadas
Copy link
Copy Markdown
Contributor Author

valadas commented Mar 12, 2023

Adding the nuget package appears to fix it.

david-poindexter
david-poindexter approved these changes Mar 12, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@david-poindexter david-poindexter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valadas this looks great! One question. I see the webpack script (which uses webpack-dev-server ...) has been removed from all the package.json files. What is replacing this? Are we recommending just using the webpack CLI now for this? If so, do the Cake scripts need to be up updated accordingly? (I honestly can't remember if those used this or not in the scoped build options.)

@valadas
Copy link
Copy Markdown
Contributor Author

valadas commented Mar 12, 2023

It was because since we have yarn start --scope something now (which we did not have back then, using the webpack task is more complex and needs the developer to setup the view to load from :8080 manually which we don't have anywhere in our docs and many already have something running on 8080 and then get into troubles, etc. Happy to bring it back if anyone mentions they actually use that task...

@david-poindexter
Copy link
Copy Markdown
Contributor

david-poindexter commented Mar 12, 2023

It was because since we have yarn start --scope something now (which we did not have back then, using the webpack task is more complex and needs the developer to setup the view to load from :8080 manually which we don't have anywhere in our docs and many already have something running on 8080 and then get into troubles, etc. Happy to bring it back if anyone mentions they actually use that task...

That makes perfect sense - thanks for the explanation. And seriously...thank you for this PR!

bdukes
bdukes reviewed Mar 13, 2023
View reviewed changes
@bdukes bdukes merged commit a77c196 into dnnsoftware:develop Mar 13, 2023
@valadas valadas mentioned this pull request Mar 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdukes bdukes bdukes approved these changes

@david-poindexter david-poindexter david-poindexter approved these changes

Assignees

No one assigned

Labels

Type: Maintenance

Projects

None yet

Milestone

9.11.2

Development

Successfully merging this pull request may close these issues.

3 participants

@valadas @david-poindexter @bdukes