Remove SQL syntax that's incompatible with 2012#5568
Merged
david-poindexter merged 1 commit intodnnsoftware:developfrom Mar 10, 2023
Merged
Remove SQL syntax that's incompatible with 2012#5568david-poindexter merged 1 commit intodnnsoftware:developfrom
david-poindexter merged 1 commit intodnnsoftware:developfrom
Conversation
DROP PROCEDURE IF EXISTS requires SQL 2016, DNN's current minimum requirements include SQL 2012 Also adjust the column existence check to be consistent with other checks Fixes dnnsoftware#5554
mitchelsellers
approved these changes
Mar 10, 2023
david-poindexter
requested changes
Mar 10, 2023
Contributor
david-poindexter
left a comment
There was a problem hiding this comment.
PR looks good but build is failing. 🤷
Merged
valadas
approved these changes
Mar 10, 2023
Contributor
valadas
left a comment
There was a problem hiding this comment.
Looks good to me
The build issue is unrelated:
I had to put a workaround in place due to Webpack4 having an issue with a breaking change in Node v18
I added --openssl-legacy-provider to the environment variables which worked in many other projects where Webpack could not be quickly upgraded to v5. It worked earlier in this project (like last week or so), not sure what has changed but it is now saying it is not allowed in NODE_OPTIONS... I'll try to take a look at that this weekend...
david-poindexter
approved these changes
Mar 10, 2023
Contributor
david-poindexter
left a comment
There was a problem hiding this comment.
Marking as approved and treating build issue separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DROP PROCEDURE IF EXISTSrequires SQL 2016, DNN's current minimum requirements include SQL 2012Also adjust the column existence check to be consistent with other checks
Fixes #5554