Temp fix Resource Manager default height#5557
Merged
david-poindexter merged 2 commits intodnnsoftware:developfrom Feb 26, 2023
Merged
Temp fix Resource Manager default height#5557david-poindexter merged 2 commits intodnnsoftware:developfrom
david-poindexter merged 2 commits intodnnsoftware:developfrom
Conversation
Temporary fix for next patch release to give the Resource Manager a better default height. In brief, the default height is currently hard-coded to 400px. This CSS-only fix instead bases the height on the browser's height using "100vh - 25rem" which basically means the resource manager's height will be (dynamically) about 400px less than the browser's height (to account for the theme's header and footer at least). We've also set a min-height of 30rem (appx 480px). Read Issue dnnsoftware#5361 for more details. dnnsoftware#5361
…height-patch Temp fix Resource Manager default height
Contributor
Author
|
david-poindexter
approved these changes
Feb 26, 2023
Contributor
david-poindexter
left a comment
There was a problem hiding this comment.
Awesome - thank you for the contribution @jeremy-farrance 🎉
Contributor
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary CSS-only fix for next DNN patch release to give the Resource Manager a better default height.
Summary
In brief, the default height is currently hard-coded to 400px. This fix instead bases the height on the browser's height using "100vh - 25rem" which basically means the resource manager's height will be (dynamically) about 400px less than the browser's height (to account for the theme's header and footer at least). We've also set a min-height of 30rem (appx 480px) so scroll bars appear, but everything functions as expected.
Temp fix, but does not close Issue #5361