Implemented a workaround to support node v18#5544
Merged
valadas merged 1 commit intodnnsoftware:release/9.11.1from Feb 22, 2023
Merged
Implemented a workaround to support node v18#5544valadas merged 1 commit intodnnsoftware:release/9.11.1from
valadas merged 1 commit intodnnsoftware:release/9.11.1from
Conversation
Azure pipelines has updated windows-latest to run on node v18.x.x Node 18 has bumped some requirements about open-ssl and Webpack 4 will not be updated to support this use case. The correct solution is to upgrade to webpack 5 but this has the potential to be a massive task. In the meantime one can pass openssl-legacy-provider for node v18 to support the legacy ssl methods. This PR is a workaround to make our current build work and be able to release DNN v9.11.1 I'll create an issue to do this in a more proper manner after I can confirm this PR fixes our issue in CI.
Contributor
Author
|
This is a release management task, as per our policy, we are self-approving it. |
Contributor
|
Glad it worked! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure pipelines has updated windows-latest to run on node v18.x.x on Febuary 17th.
Node 18 has bumped some requirements about open-ssl and Webpack 4 will not be updated to support this use case.
The correct solution is to upgrade to webpack 5 but this has the potential to be a massive task. In the meantime one can pass openssl-legacy-provider for node v18 to support the legacy ssl methods. This PR is a workaround to make our current build work and be able to release DNN v9.11.1 I'll create an issue to do this in a more proper manner after I can confirm this PR fixes our issue in CI.
Summary