Fix #5533 - Null checker on EditorHostSetting#5535
Merged
valadas merged 1 commit intodnnsoftware:developfrom Feb 8, 2023
Merged
Fix #5533 - Null checker on EditorHostSetting#5535valadas merged 1 commit intodnnsoftware:developfrom
valadas merged 1 commit intodnnsoftware:developfrom
Conversation
mitchelsellers
approved these changes
Feb 8, 2023
Contributor
mitchelsellers
left a comment
There was a problem hiding this comment.
This looks reasonable to me
valadas
approved these changes
Feb 8, 2023
Contributor
valadas
left a comment
There was a problem hiding this comment.
Looks good to me and tested the CI build, I confirm it fixes both the server browser and the editor manger. Thanks! Releasing an RC3 in a few minutes...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #5533 - Error happen due filteredSettings is null.