Fix Path.Combine with glbConfigFolder#5526
Merged
david-poindexter merged 2 commits intodnnsoftware:release/9.11.1from Feb 6, 2023
Merged
Fix Path.Combine with glbConfigFolder#5526david-poindexter merged 2 commits intodnnsoftware:release/9.11.1from
david-poindexter merged 2 commits intodnnsoftware:release/9.11.1from
Conversation
Since Globals.glbConfigFolder starts with a slash, using it in Path.Combine causes that section of the path to become the path root, instead of being appended to the previous path, as it was with plain string concatenation
valadas
reviewed
Feb 4, 2023
Contributor
valadas
left a comment
There was a problem hiding this comment.
Build appears to be failing due to a missing closing parenthesis...
Co-authored-by: Daniel Valadas <info@danielvaladas.com>
david-poindexter
approved these changes
Feb 6, 2023
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since
Globals.glbConfigFolderstarts with a slash ("\\Config\\"), using it inPath.Combinecauses that section of the path to become the path root, instead of being appended to the previous path, as it was with plain string concatenationFixes #5522