Skip to content

Bump fbjs from 1.0.0 to 3.0.4#5517

Merged
valadas merged 1 commit intodevelopfrom
dependabot/npm_and_yarn/fbjs-3.0.4
Mar 21, 2023
Merged

Bump fbjs from 1.0.0 to 3.0.4#5517
valadas merged 1 commit intodevelopfrom
dependabot/npm_and_yarn/fbjs-3.0.4

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Feb 1, 2023 •
edited
Loading

Bumps fbjs from 1.0.0 to 3.0.4.

Commits
Maintainer changes

This version was pushed to npm by bigfootjon, a new releaser for fbjs since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added javascript Pull requests that update Javascript code Type: Maintenance labels Feb 1, 2023
@bdukes bdukes added this to the 9.11.2 milestone Feb 6, 2023
@valadas
Copy link
Copy Markdown
Contributor

valadas commented Feb 18, 2023

I would like to run a yarn why to see what needs this library before merging...

@bdukes
Copy link
Copy Markdown
Contributor

bdukes commented Feb 20, 2023

It's a devDependency in the package.json for Prompt, but I don't see any direct usages

Dnn.Platform/Dnn.AdminExperience/ClientSide/Prompt.Web/package.json

Line 41 in 4cac2cc

"fbjs": "*",

A number of react packages depend on it (react 15 depends on it, react 16 does not):

Dnn.Platform/yarn.lock

Lines 9196 to 9202 in 4cac2cc

"create-react-class@npm:^15.6, create-react-class@npm:^15.6.0, create-react-class@npm:^15.6.3":
version: 15.6.3
resolution: "create-react-class@npm:15.6.3"
dependencies:
fbjs: ^0.8.9
loose-envify: ^1.3.1
object-assign: ^4.1.1

Dnn.Platform/yarn.lock

Lines 9220 to 9225 in 4cac2cc

"create-react-context@npm:<=0.2.2":
version: 0.2.2
resolution: "create-react-context@npm:0.2.2"
dependencies:
fbjs: ^0.8.0
gud: ^1.0.0

Dnn.Platform/yarn.lock

Lines 9233 to 9238 in 4cac2cc

"create-react-context@npm:^0.2.1":
version: 0.2.3
resolution: "create-react-context@npm:0.2.3"
dependencies:
fbjs: ^0.8.0
gud: ^1.0.0

Dnn.Platform/yarn.lock

Lines 20889 to 20897 in 4cac2cc

"react@npm:15":
version: 15.6.2
resolution: "react@npm:15.6.2"
dependencies:
create-react-class: ^15.6.0
fbjs: ^0.8.9
loose-envify: ^1.1.0
object-assign: ^4.1.0
prop-types: ^15.5.10

Dnn.Platform/yarn.lock

Lines 21149 to 21158 in 4cac2cc

"recompose@npm:^0.30.0":
version: 0.30.0
resolution: "recompose@npm:0.30.0"
dependencies:
"@babel/runtime": ^7.0.0
change-emitter: ^0.1.2
fbjs: ^0.8.1
hoist-non-react-statics: ^2.3.1
react-lifecycles-compat: ^3.0.2
symbol-observable: ^1.0.4

html-react-parser is another (non-dev) dependency of the Prompt project, and it's the reason React 15 is being included.

Dnn.Platform/yarn.lock

Lines 13284 to 13291 in 4cac2cc

"html-react-parser@npm:^0.7.0":
version: 0.7.0
resolution: "html-react-parser@npm:0.7.0"
dependencies:
"@types/domhandler": 2.4.1
html-dom-parser: 0.2.1
react-dom-core: 0.0.4
style-to-object: 0.2.2

Dnn.Platform/yarn.lock

Lines 20291 to 20295 in 4cac2cc

"react-dom-core@npm:0.0.4":
version: 0.0.4
resolution: "react-dom-core@npm:0.0.4"
dependencies:
react: 15

@bdukes
Copy link
Copy Markdown
Contributor

bdukes commented Feb 20, 2023 

yarn why fbjs
├─ create-react-class@npm:15.6.3
│  └─ fbjs@npm:0.8.17 (via npm:^0.8.9)
│
├─ create-react-context@npm:0.2.2
│  └─ fbjs@npm:0.8.17 (via npm:^0.8.0)
│
├─ create-react-context@npm:0.2.3
│  └─ fbjs@npm:0.8.17 (via npm:^0.8.0)
│
├─ create-react-context@npm:0.2.2 [42e0c]
│  └─ fbjs@npm:0.8.17 (via npm:^0.8.0)
│
├─ create-react-context@npm:0.2.3 [51537]
│  └─ fbjs@npm:0.8.17 (via npm:^0.8.0)
│
├─ create-react-context@npm:0.2.3 [9c345]
│  └─ fbjs@npm:0.8.17 (via npm:^0.8.0)
│
├─ create-react-context@npm:0.2.3 [f4506]
│  └─ fbjs@npm:0.8.17 (via npm:^0.8.0)
│
├─ prompt@workspace:Dnn.AdminExperience/ClientSide/Prompt.Web
│  └─ fbjs@npm:1.0.0 (via npm:*)
│
├─ react@npm:15.6.2
│  └─ fbjs@npm:0.8.17 (via npm:^0.8.9)
│
├─ recompose@npm:0.30.0
│  └─ fbjs@npm:0.8.17 (via npm:^0.8.1)
│
└─ recompose@npm:0.30.0 [e5038]
   └─ fbjs@npm:0.8.17 (via npm:^0.8.1)

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/fbjs-3.0.4 branch from d917fe1 to a2387fb Compare February 22, 2023 05:51
@dependabot
Bump fbjs from 1.0.0 to 3.0.4
c8f567a 
Bumps [fbjs](https://github.com/facebook/fbjs) from 1.0.0 to 3.0.4.
- [Release notes](https://github.com/facebook/fbjs/releases)
- [Commits](facebook/fbjs@fbjs-v1.0.0...fbjs-v3.0.4)

---
updated-dependencies:
- dependency-name: fbjs
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/fbjs-3.0.4 branch from a2387fb to c8f567a Compare March 13, 2023 18:38
valadas
valadas approved these changes Mar 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good then

@valadas valadas merged commit 9e46804 into develop Mar 21, 2023
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/fbjs-3.0.4 branch March 21, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdukes bdukes bdukes approved these changes

@valadas valadas valadas approved these changes

Assignees

No one assigned

Labels

javascript Pull requests that update Javascript code Type: Maintenance

Projects

None yet

Milestone

9.11.2

Development

Successfully merging this pull request may close these issues.

2 participants

@valadas @bdukes