Centralize all portal template operations in the library project#5387
Merged
valadas merged 6 commits intodnnsoftware:developfrom Nov 13, 2022
Merged
Centralize all portal template operations in the library project#5387valadas merged 6 commits intodnnsoftware:developfrom
valadas merged 6 commits intodnnsoftware:developfrom
Conversation
valadas
requested changes
Nov 11, 2022
Contributor
valadas
left a comment
There was a problem hiding this comment.
Everything looks good to me except the PortalTemplate deletion without deprecation warning
DNN Platform/Library/Entities/Portals/Templates/PortalTemplate.cs
Outdated
Show resolved
Hide resolved
valadas
reviewed
Nov 13, 2022
DNN Platform/Library/Entities/Portals/Templates/IPortalTemplateController.cs
Show resolved
Hide resolved
DNN Platform/Library/Entities/Portals/Templates/PortalTemplateController.cs
Show resolved
Hide resolved
valadas
approved these changes
Nov 13, 2022
Contributor
valadas
left a comment
There was a problem hiding this comment.
Everything looks ok to me.
mitchelsellers
approved these changes
Nov 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the code for the creation of portal templates is in the AE Extensions library making it inaccessible to developers. This code is now moved to the main library.
Currently the code for the "application" of a portal template is in the PortalController. Given it is in the order of 1.5K lines of code it seriously bloats the PortalController code. This code is now moved to "PortalTemplateImporter".
To provide access to portal templates a new controller is created: PortalTemplateController which now has two methods: one for creating a portal template and one for the application of a portal template.