Fix localizing parent tabs breaking existing localized child tabs#5382
Fix localizing parent tabs breaking existing localized child tabs#5382mitchelsellers merged 2 commits intodnnsoftware:developfrom trilogy-group:bugfix/DNN-62258
Conversation
|
|
|
@mwigley-trilogy Can we get details on the recreation steps, and what was the actual issue in this situation that is being resolved. |
|
Ah, sorry @mitchelsellers! I just realised that that I just created this PR in the public repo, I'll close this PR and remake once I've created an issue with repro steps. |
|
No need to close @mwigley-trilogy just add the issue with detail and we can review! |
|
This fixes: #5383 edit: removed mentioning that CLA bot is broken because I thought maybe it was my VPN but it's not my VPN, so readding:
|
|
@mitchelsellers I have some info about a possible cla bot being broken, ping me up when able... |
valadas
left a comment
There was a problem hiding this comment.
Thanks for the detailed issue, really helped understand the issue and the fix.
This PR makes sense to me.
|
@mwigley-trilogy There appears to be a temporary issue with the CLA bot at the moment, we contacted .Net Foundation and are just waiting on a reply/fix... Quick question, usually when one goes there for the first time, they get a first view and a button to login to github to then continue on to the signing part. |
|
@valadas Today I'm getting this:
click ->
Yesterday I got the authorise app confirmation part and approved it. Yesterday I got a few different errors, initially I got an error straight away on clicking the 'sign now' link, later I got the 'sign with github' button and could authorize the integration, and could fill out the part of the form that approved access, but then got an error when clicking the sign button. So in summary I think I've seen an error at each point in the process :) |
|
@mwigley-trilogy Are you an Employee of IgniteTech/DNNSoftware/Whatever level of the company |
|
@mitchelsellers Yes, I'm a new VP of Software Engineering for Trilogy |
|
@mwigley-trilogy Thank you for your contributions first of all, secondly, we will accept your PR's for now given your status as we work through the CLA bot issues with the .NET Foundation and will get you signed in the coming days. @valadas keep me updated on the CLA bot stuff. |
Fix localizing parent tabs breaking existing localized child tabs by updating the child->parent tab links when localizing parent tabs.
Closes #5383